refactor: /simplify — 22 fixes from 3-agent code review

Critical:
- Fix MXC URI resolution: all avatars/images now resolve mxc:// to HTTP
- Sync persistence: only write changed rooms, batch message upserts
- lastActivityAt uses room.lastEvent.originServerTs, not creation time

High:
- Shared MatrixAvatar widget replaces 6 duplicate implementations
- CallScreen decodes roomId before LiveKit JWT fetch
- Decline button actually dismisses incoming call overlay
- EventTypes constants replace raw string literals
- LiveKitService uses lazy auth reads, onDispose disconnects

Medium:
- CallController is keepAlive with timer/room cleanup
- authRepository is keepAlive (used from keepAlive notifier)
- StreamController not closed in stopListening (crash fix)
- Index on messages.roomId for query performance
- 400ms debounce on user search
- Static DateFormat in MessageBubble
- Hardcoded strings replaced with AppConfig refs
- Duplicate isDirectMessage field removed from RoomModel
- E2EE profile claim corrected to Phase 3

Shared utilities:
- lib/shared/widgets/matrix_avatar.dart
- lib/shared/utils/mxc_url.dart
- lib/shared/utils/room_preview.dart
- lib/shared/utils/matrix_id.dart

rawJson column removed (unused, caused main-thread jsonEncode)
Schema migrated to v2 with roomId index.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-02 13:19:22 +10:00
parent 96550c3411
commit b941cdfe4b
23 changed files with 355 additions and 346 deletions

View File

@@ -0,0 +1,16 @@
// Version: 1.0.0 | Created: 2026-04-02
// Utility extension for extracting the localpart from a Matrix user ID.
// Matrix IDs have the form @localpart:server.name — this extracts "localpart".
/// Extension on [String] for Matrix user ID operations.
extension MatrixIdExtension on String {
/// Extracts the localpart from a Matrix user ID.
///
/// Example: `'@alice:matrix.m8chat.au'.matrixLocalpart` returns `'alice'`.
/// Returns the original string unchanged if it does not match the expected
/// `@localpart:server` format.
String get matrixLocalpart {
final value = split(':').first.replaceFirst('@', '');
return value.isEmpty ? this : value;
}
}

View File

@@ -0,0 +1,28 @@
// Version: 1.0.0 | Created: 2026-04-02
// Synchronous MXC URI to HTTP URL resolution.
// Avatars and thumbnails in the room list / sync service need a resolved HTTP
// URL. The Matrix SDK's getDownloadUri() is async (checks authenticated media
// support), but for avatar display we need a synchronous result.
//
// This helper builds the legacy v3 media URL which works on all homeservers.
import 'package:matrix/matrix.dart';
/// Resolves an `mxc://` [Uri] to an HTTP download URL using the client's
/// homeserver. Returns `null` if the URI is not an mxc scheme or the client
/// has no homeserver set.
///
/// This is synchronous — suitable for use in non-async model mapping.
String? resolveMxcUrl(Client client, Uri? mxcUri) {
if (mxcUri == null || !mxcUri.isScheme('mxc')) return null;
final homeserver = client.homeserver;
if (homeserver == null) return null;
// Build the media download path per the Matrix spec.
final serverName = mxcUri.host;
final port = mxcUri.hasPort ? ':${mxcUri.port}' : '';
final mediaId = mxcUri.path; // includes leading /
return homeserver
.resolve('_matrix/media/v3/download/$serverName$port$mediaId')
.toString();
}

View File

@@ -0,0 +1,19 @@
// Version: 1.0.0 | Created: 2026-04-02
// Shared utility for generating a last-message preview string from a Room.
// Used by both RoomsRepository and SyncPersistenceService to avoid duplication.
import 'package:matrix/matrix.dart';
/// Returns a human-readable preview of the room's last event, or null if there
/// is no suitable event to preview.
String? lastMessagePreview(Room room) {
final lastEvent = room.lastEvent;
if (lastEvent == null) return null;
return switch (lastEvent.type) {
EventTypes.Message => lastEvent.body,
EventTypes.Encrypted => 'Encrypted message',
EventTypes.Sticker => 'Sticker',
_ => null,
};
}

View File

@@ -0,0 +1,54 @@
// Version: 1.0.0 | Created: 2026-04-02
// Shared avatar widget used throughout the app. Displays a cached network
// image when an HTTP avatar URL is available, or falls back to a coloured
// circle with the first letter of the display name.
//
// The [avatarUrl] MUST be a resolved HTTP URL — never pass an mxc:// URI.
import 'package:cached_network_image/cached_network_image.dart';
import 'package:flutter/material.dart';
class MatrixAvatar extends StatelessWidget {
const MatrixAvatar({
super.key,
required this.name,
this.avatarUrl,
this.radius = 20,
});
/// Display name used for the initials fallback.
final String name;
/// Resolved HTTP URL for the avatar image. Must NOT be an mxc:// URI.
final String? avatarUrl;
/// Radius of the [CircleAvatar].
final double radius;
@override
Widget build(BuildContext context) {
final theme = Theme.of(context);
final initials = name.isNotEmpty ? name[0].toUpperCase() : '?';
if (avatarUrl != null) {
return CircleAvatar(
radius: radius,
backgroundImage: CachedNetworkImageProvider(avatarUrl!),
backgroundColor: theme.colorScheme.surfaceContainerHighest,
);
}
return CircleAvatar(
radius: radius,
backgroundColor: theme.colorScheme.primary.withAlpha(51),
child: Text(
initials,
style: TextStyle(
fontSize: radius * 0.7,
fontWeight: FontWeight.bold,
color: theme.colorScheme.primary,
),
),
);
}
}